Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a codec match algorithm for setCodecPreferences #2847

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Add a codec match algorithm for setCodecPreferences #2847

merged 2 commits into from
Mar 30, 2023

Conversation

Orphis
Copy link
Contributor

@Orphis Orphis commented Mar 27, 2023 •
edited by pr-preview bot
Loading

Also remove impossible to implement steps in setCodecPreferences, as it's always possible to modify a dictionary.

Fixes #2845.

Preview | Diff

@Orphis Orphis requested a review from jan-ivar March 27, 2023 16:06
jan-ivar
jan-ivar requested changes Mar 28, 2023
View reviewed changes
webrtc.html Outdated Show resolved Hide resolved
webrtc.html Outdated Show resolved Hide resolved
webrtc.html Outdated Show resolved Hide resolved
@jan-ivar jan-ivar mentioned this pull request Mar 28, 2023
Closed
@Orphis Orphis removed the Editorial label Mar 29, 2023
@Orphis Orphis requested a review from jan-ivar March 29, 2023 14:44
jan-ivar
jan-ivar reviewed Mar 29, 2023
View reviewed changes
webrtc.html Outdated Show resolved Hide resolved
webrtc.html Outdated Show resolved Hide resolved
@Orphis Orphis requested a review from jan-ivar March 30, 2023 12:33
jan-ivar
jan-ivar reviewed Mar 30, 2023
View reviewed changes
webrtc.html Outdated Show resolved Hide resolved
webrtc.html Outdated Show resolved Hide resolved
webrtc.html Outdated Show resolved Hide resolved
webrtc.html Outdated Show resolved Hide resolved
@jan-ivar
Copy link
Member

But overall as expressed earlier, I have some concerns about an A B comparison across codec types. @alvestrand has some useful comments in w3c/media-capabilities#185 (comment) that I think are clarifying.

@Orphis
Add a codec match algorithm for setCodecPreferences
16d7580 
Also remove impossible to implement steps in setCodecPreferences,
as it's always possible to modify a dictionary.

Fixes w3c#2845.
@Orphis Orphis requested a review from jan-ivar March 30, 2023 14:17
jan-ivar
jan-ivar reviewed Mar 30, 2023
View reviewed changes
webrtc.html Outdated Show resolved Hide resolved
@henbos @jan-ivar
Update webrtc.html
2c6f622 
Co-authored-by: Jan-Ivar Bruaroey <[email protected]>
@henbos henbos merged commit ed6a216 into w3c:main Mar 30, 2023
dontcallmedom added a commit that referenced this pull request Apr 3, 2023
@dontcallmedom
Fix description of amendment 31
fbed206 
missed from #2847
dontcallmedom added a commit that referenced this pull request Apr 3, 2023
@dontcallmedom
Fix description of amendment 31
465d30f 
missed from #2847
@dontcallmedom dontcallmedom mentioned this pull request Nov 15, 2023
Merged
23 tasks
@jan-ivar jan-ivar mentioned this pull request Apr 17, 2024
Closed
@dontcallmedom dontcallmedom mentioned this pull request Sep 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henbos henbos henbos approved these changes

@jan-ivar jan-ivar jan-ivar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What is setCodecPreferences's contract?
3 participants
@Orphis @jan-ivar @henbos